Updates to Github #github


HBlink@DVSwitch.groups.io Integration <HBlink@...>
 

[hblink3:master] New Comment on Issue #3 Problem connectig to hblink
By randybuildsthings:

Just going to state that if you're connecting to another HBLink instance, you really should look at using OpenBridge and setting it up the connection that way (much like you would with any of the DVSwitch services), rather than having HBLink masquerade as a peer/repeater on a master server. There is the option in OpenBridge of passing traffic on both slots 1 & 2, rather than just slot 1 (which is how BrandMeister wants to use OpenBridge connections).


[hblink3:master] Issue #3 Problem connectig to hblink closed by bouab002.


HBlink@DVSwitch.groups.io Integration <HBlink@...>
 

[hblink3:master] Label added to issue #9 Talker Alias causes an Exception by marrold.


[hblink3:master] New Comment on Issue #9 Talker Alias causes an Exception
By randybuildsthings:

Let's just use the first one, since this looks like a literal duplicate.


[hblink3:master] Issue #9 Talker Alias causes an Exception closed by marrold.


[hblink3:master] Label added to issue #5 HBlink crash (memory leak)? by K2IE.


[hblink3:master] New Comment on Issue #5 HBlink crash (memory leak)?
By randybuildsthings:

I will keep this in the mix for now, as it needs to be looked at. Generally speaking, having the reactor kill itself rather than exhaust all memory in the system is admittedly a better solution for the moment, but detecting that a memory leak condition is happening is not better than avoiding it or correcting it as you go. So, I'll keep this open until there's time to look at the nature of the memory leak and if it's possible to set things up so that resources can be cleaned up and deallocated, so as to avoid the memory leak condition.


[hblink3:master] Label added to issue #8 Talker Alias causes an Exception by marrold.


[hblink3:master] New Comment on Issue #8 Talker Alias causes an Exception
By randybuildsthings:

It's a testament to how rare DMRA frames are that this has only just come up now. This has been in the code base for a little while, and I would imagine there are lots of people using this.

Most Talker Alias info is embedded inside of DMRD frames, so I'll have to go back and look at MMDVMHost to see how these frames are structured.


[hblink3:master] Label added to issue #3 Problem connectig to hblink by bouab002.


HBlink@DVSwitch.groups.io Integration <HBlink@...>
 

[hblink3:master] New Issue Created by marrold:
#8 Talker Alias causes an Exception

Hi,

I am using hblink in a bridged configuration and have noticed DMRA frames cause an exception in the logs:

Unhandled Error
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/log.py", line 86, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/internet/posixbase.py", line 614, in _doReadOrWrite
    why = selectable.doRead()
--- <exception caught here> ---
  File "/usr/local/lib/python3.7/dist-packages/twisted/internet/udp.py", line 249, in doRead
    self.protocol.datagramReceived(data, addr)
  File "/opt/hblink3/hblink.py", line 532, in master_datagramReceived
    logger.info('(%s) Recieved DMR Talker Alias from peer %s, subscriber %s', self._system, self._peers[_peer_id]['CALLSIGN'], int_id(_rf_src))
builtins.UnboundLocalError: local variable '_rf_src' referenced before assignment

Looking at the code, _rf_src is indeed referenced before assignment. A quick fix would be to just pass DMRA frames but it would be nice to extract the info I guess.

Thanks Matthew 2E0SIP


[hblink3:master] New Issue Created by marrold:
#9 Talker Alias causes an Exception

Hi,

I am using hblink in a bridged configuration and have noticed DMRA frames cause an exception in the logs:

Unhandled Error
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/log.py", line 86, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/usr/local/lib/python3.7/dist-packages/twisted/internet/posixbase.py", line 614, in _doReadOrWrite
    why = selectable.doRead()
--- <exception caught here> ---
  File "/usr/local/lib/python3.7/dist-packages/twisted/internet/udp.py", line 249, in doRead
    self.protocol.datagramReceived(data, addr)
  File "/opt/hblink3/hblink.py", line 532, in master_datagramReceived
    logger.info('(%s) Recieved DMR Talker Alias from peer %s, subscriber %s', self._system, self._peers[_peer_id]['CALLSIGN'], int_id(_rf_src))
builtins.UnboundLocalError: local variable '_rf_src' referenced before assignment

Looking at the code, _rf_src is indeed referenced before assignment. A quick fix would be to just pass DMRA frames but it would be nice to extract the info I guess.

Thanks Matthew 2E0SIP